Feature/FOUR-10790: Multiplayer support for boundary events #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agustinbusso
requested review from
josechirivella,
devmiguelangel and
rodriquelca
and removed request for
josechirivella and
devmiguelangel
josechirivella
suggested changes
Oct 12, 2023
src/components/modeler/Selection.vue
Outdated
| boundaryTimerEventId, | ||
| ]; | ||
|
|
||
| const boundaryNodes = window.ProcessMaker.$modeler.nodes.filter(node => boundaryEventTypes.includes(node.type)); |
There was a problem hiding this comment.
Uhmm I'm pretty sure this nodes are available in the store?
Also, window.ProcessMaker.$modeler is a ref I believe also. Can you confirm @rodriquelca
| attachedToRef: this.node.definition.get('attachedToRef'), | ||
| }; | ||
|
|
||
| const { paper } = window.ProcessMaker.$modeler; |
There was a problem hiding this comment.
same goes here, the paper should be available in the store or ref
src/multiplayer/multiplayer.js
Outdated
| // Trigger a rendering of the element on the paper | ||
| paper.findViewByModel(element).update(); | ||
| } | ||
| attachBoundaryEventToNode(element, data) { | ||
| const { paper } = this.modeler; | ||
| let node = this.getNodeById(data.attachedToRefId); |
There was a problem hiding this comment.
Suggested change
| let node = this.getNodeById(data.attachedToRefId); | |
| const node = this.getNodeById(data.attachedToRefId); |
rodriquelca
approved these changes
Oct 20, 2023
josechirivella
approved these changes
Oct 20, 2023
devmiguelangel
approved these changes
Oct 23, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Boundary events in collaborative modeler
Related PRs
Screen.Recording.2023-10-12.at.11.10.05.mov
Screen.Recording.2023-10-12.at.16.28.59.mov